osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jira] [Comment Edited] (ARIES-1877) Array type properties do not evaluate as equal on reload update strategy (blueprint-cm)


    [ https://issues.apache.org/jira/browse/ARIES-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719409#comment-16719409 ] 

Shannon Gallagher edited comment on ARIES-1877 at 12/12/18 9:21 PM:
--------------------------------------------------------------------

I've put up a PR to fix this that does an Arrays.deepEquals comparison if the two properties are arrays.

[https://github.com/apache/aries/pull/93]


was (Author: sgalla):
I've put up a PR to fix this

https://github.com/apache/aries/pull/93

> Array type properties do not evaluate as equal on reload update strategy (blueprint-cm)
> ---------------------------------------------------------------------------------------
>
>                 Key: ARIES-1877
>                 URL: https://issues.apache.org/jira/browse/ARIES-1877
>             Project: Aries
>          Issue Type: Bug
>          Components: Blueprint
>    Affects Versions: blueprint-cm-1.3.0
>            Reporter: Shannon Gallagher
>            Priority: Major
>
> When the CmPropertyPlaceholder is evaluating if configurations have been updated and it needs to reload, there is a bug if the properties being compared are arrays. In our use case, we are seeing string arrays that should be equal evaluate as not equal.
> Code in question: https://github.com/apache/aries/blob/1afa8a3c181cca7896a764d4f9e902623873a172/blueprint/blueprint-cm/src/main/java/org/apache/aries/blueprint/compendium/cm/CmPropertyPlaceholder.java#L158-L160



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)