osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2482: ARTEMIS-2214 Cache durable&priority in ...


GitHub user qihongxu opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2482

    ARTEMIS-2214 Cache durable&priority in PagedReference

    We recently performed a test on artemis broker and found a severe performance issue.
    
    When paged messages are being consumed, decrementMetrics in QueuePendingMessageMetrics will try to â??getMessageâ?? to check whether they are durable or not. In this way queue will be locked for a long time because page may be GCed and need to be reload entirely. Other operations rely on queue will be blocked at this time, which cause a significant TPS drop. Detailed stacks are attached below.
    
    This also happens when consumer is closed and messages are pushed back to the queue, artemis will check priority on return if these messages are paged.
    
    To solve the issue, durable and priority need to be cached in PagedReference just like messageID, transactionID and so on. I have applied a patch to fix the issue. Any review is appreciated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qihongxu/activemq-artemis modify_pagedReference

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2482
    
----
commit a49ad880c2372afdb88bd805fb6e20fdae1de784
Author: Qihong Xu <qihongxu@...>
Date:   2018-12-26T03:11:10Z

    ARTEMIS-2214 Cache durable&priority in PagedReference

----


---