osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2478: ARTEMIS-2210 PagingStore creation is no...


Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2478#discussion_r243866712
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java ---
    @@ -335,19 +335,25 @@ public void deletePageStore(final SimpleString storeName) throws Exception {
        }
     
        /**
    -    * stores is a ConcurrentHashMap, so we don't need to synchronize this method
    +    * This method creates a new store if not exist.
         */
        @Override
        public PagingStore getPageStore(final SimpleString storeName) throws Exception {
           if (managementAddress != null && storeName.startsWith(managementAddress)) {
              return null;
           }
    -      PagingStore store = stores.get(storeName);
     
    -      if (store != null) {
    -         return store;
    +      try {
    --- End diff --
    
    ok got it. I've updated the branch. Please take a look again. thx.


---