osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis issue #2468: Add CR in sanity check


Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2468
  
    After looking at this a bit more closely I think this change is incorrect. The optional carriage return (octet 13) was added in STOMP 1.2, but you have changed `org.apache.activemq.artemis.core.protocol.stomp.StompDecoder` which is responsible for STOMP 1.0 frames. There are different decoder implementations for STOMP 1.1 & 1.2, and from what I can tell the 1.2 decoder handles the EOL properly. In fact, the STOMP client used by the test suite sends `\r\n` EOLs by default when using STOMP 1.2. 
    
    Unless you have a test demonstrating a problem I think this PR should be closed.


---