[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2458: ARTEMIS-2199 PagingStore leak when dele...

Github user jbertram commented on a diff in the pull request:

    --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java ---
    @@ -1719,11 +1720,11 @@ public void callback(SimpleString queueName) throws Exception {
           public void callback(SimpleString address, SimpleString queueName) throws Exception {
              Queue queue = server.locateQueue(address);
    -         Collection<Binding> bindings = server.getPostOffice().getBindingsForAddress(address).getBindings();
    --- End diff --
    This callback doesn't exist on master so there's no direct counterpart for this fix. However, I do plan on reviewing all the usages of `getBindingsForAddress` to try to find similar problems.