osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2287: ARTEMIS-2069 Backup doesn't activate af...


Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2287#discussion_r240232734
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java ---
    @@ -49,6 +49,8 @@
     
        private static final byte NOT_STARTED = 'N';
     
    +   private static final long LOCK_ACCESS_FAILURE_WAIT_TIME = 2000;
    --- End diff --
    
    You are here effectively ignoring the acquire timeout where the user can configure it. I'm not sure this is correct.
    
    your test should play with a configured timeout and see if you get the expected behaviour. Adding this you are forcing your own timeout bypassing the configured one.


---