osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...


Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2448#discussion_r238416943
  
    --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java ---
    @@ -265,6 +266,126 @@ public void testTemporaryQueueDeleted() throws Exception {
           }
        }
     
    +   @Test
    +   public void testTemporaryQueueDeletedAfterSessionClosed() throws Exception {
    --- End diff --
    
    For AMQP the handling of dynamic nodes is tested here:
    https://github.com/apache/activemq-artemis/blob/master/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpTempDestinationTest.java
    And here:
    https://github.com/apache/activemq-artemis/blob/master/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSTemporaryDestinationTest.java
    
    For OpenWire you'd want to look for a test of the RemoveInfo command that carries a DestintionInfo object.
    
    Other tests that are specifically targeted the JMS spec (or other) compliant behaviour of a client really belong to the project that maintains the client in question.


---