osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2334: ARTEMIS-2098 potential NPE when decodin...


Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2334#discussion_r220700987
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java ---
    @@ -196,6 +196,10 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in, List<Object> out) t
              }
     
              ProtocolManager protocolManagerToUse = protocolMap.get(protocolToUse);
    +         if (protocolManagerToUse == null) {
    +            ActiveMQServerLogger.LOGGER.failedToFindProtocolManager(ctx.channel().remoteAddress().toString(), ctx.channel().localAddress().toString(), protocolToUse, protocolMap.keySet().toString());
    --- End diff --
    
    I performed manual testing to confirm the logging works as expected, but I'm not 100% sure these won't *ever* be null so checks are worth doing.


---