osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2330: ARTEMIS-2087 fix NPE; mask password in ...


Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2330#discussion_r220325428
  
    --- Diff: examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/management.xml ---
    @@ -21,9 +21,9 @@
              connector-host="localhost"
              secured="true"
              key-store-path="${data.dir}/../etc/server-side-keystore.jks"
    -         key-store-password="secureexample"
    --- End diff --
    
    I actually reproduced the NPE using the "jmx" example. The "jmx-ssl" example provides a perfect place to demonstrate a masked password in management.xml.  Using an unmasked password is pretty obvious so not especially helpful in an example, IMO.


---