osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...


Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2305#discussion_r217584046
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java ---
    @@ -223,7 +224,7 @@ private int read(StorageManager storage, ActiveMQBuffer fileBuffer, List<PagedMe
     
        public synchronized void write(final PagedMessage message) throws Exception {
           if (!file.isOpen()) {
    -         return;
    +         throw new ActiveMQIOErrorException("can't write to closed file " + file);
    --- End diff --
    
    ok. I thought about a jira before but I didn't do it as the code change is so few. :)



---