OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2222: ARTEMIS-2014 Treat inability to create ...


Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2222#discussion_r208364209
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java ---
    @@ -224,8 +224,10 @@ public void releaseBuffer(final ByteBuffer buffer) {
        @Override
        public void createDirs() throws Exception {
           boolean ok = journalDir.mkdirs();
    -      if (!ok) {
    -         throw new IOException("Failed to create directory " + journalDir);
    +      if (!ok && !journalDir.exists()) {
    --- End diff --
    
    @jbertram Looks good.  I would consider also wrapping the whole thing in a try, catch(Throwable).  Different JVM implementations might handle the IO Exception differently e.g. throw a RuntimeException.


---