[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2211: Redistfix

GitHub user michaelandrepearce opened a pull request:



    Here's a slight alternative option to your pr (https://github.com/apache/activemq-artemis/pull/2209) i took the fixes for the server and control, but in the queueimpl I wanted to keep away from having the redistributor in the list (reason being later where want to try make the dispatch policies more pluggable it makes it very hard)
    Also interestingly applying the same change that Franz has done for CPU here:
    But for the redistributor fixes many of the redistributor issues. 
    One case in the messageredistributiontest though still fails (testRedistributionWithMessageGroups), im looking into why it might, but if you can spot please do tell.
    If you need master fixed asap, maybe merge your PR, and i can pr this over the top once i figure it out.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis REDISTFIX

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2211
commit 59520b9018d4a44fffa0bf05c49970d50ed69ab5
Author: Clebert Suconic <clebertsuconic@...>
Date:   2018-08-02T02:04:31Z

    ARTEMIS-856 Fixing QueueCommandTest

commit f0aca5c953cb3712e668bdfa72dd3fceb7c164e1
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-08-02T09:51:27Z

    ARTEMIS-856 Fixing MessageRedistributionTest