[GitHub] activemq-artemis pull request #2211: Redistfix
GitHub user michaelandrepearce opened a pull request:
Here's a slight alternative option to your pr (https://github.com/apache/activemq-artemis/pull/2209) i took the fixes for the server and control, but in the queueimpl I wanted to keep away from having the redistributor in the list (reason being later where want to try make the dispatch policies more pluggable it makes it very hard)
Also interestingly applying the same change that Franz has done for CPU here:
But for the redistributor fixes many of the redistributor issues.
One case in the messageredistributiontest though still fails (testRedistributionWithMessageGroups), im looking into why it might, but if you can spot please do tell.
If you need master fixed asap, maybe merge your PR, and i can pr this over the top once i figure it out.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis REDISTFIX
Alternatively you can review and apply these changes as the patch at:
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2211
Author: Clebert Suconic <clebertsuconic@...>
ARTEMIS-856 Fixing QueueCommandTest
Author: Michael AndrÃ© Pearce <michael.andre.pearce@...>
ARTEMIS-856 Fixing MessageRedistributionTest