osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis issue #2206: ARTEMIS-2003 - Add bridge metrics


Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2206
  
    > Also, honestly I don't know that it's a great idea to start making this change everywhere if it only works for a single thread because in the future if someone refactors something and it no longer is a single thread for the writer then the metrics will be broken.
    
    I agree with that, indeed is more an API hints: instead of `incrementXXXMetrics` it should be provided `exclusiveIncrementXXXMetrics` too to allow (if makes sense) to do it with single writer semantic.
    It is not a proposal specific for this change, but believe me that if is used on the hot paths it can be easily a silent (for most profilers) bottleneck with a multiprocessor arch: I wouldn't point it if the impact would be just negligible :)


---