osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...


Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2187#discussion_r206424803
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java ---
    @@ -189,16 +185,24 @@ public void kill() {
           this.killed = true;
        }
     
    +   private void setHandlers() {
    +      sessionChannel.setCommandConfirmationHandler(commandConfirmationHandler);
    --- End diff --
    
    This was meant to be either newer response handler or the older command confirm handler. The intent was both shouldn't be set. This may be the reason of your dupes issue, what was this needed still even with the async response change?


---