OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests


Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2174#discussion_r201008853
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformerTest.java ---
    @@ -361,7 +361,7 @@ public void testConvertEmptyObjectMessageToAmqpMessageWithAmqpValueBody() throws
           assertNotNull(amqp.getBody());
           assertTrue(amqp.getBody() instanceof AmqpValue);
           assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof Binary);
    -      assertEquals(0, ((Binary) ((AmqpValue) amqp.getBody()).getValue()).getLength());
    +      assertEquals(5, ((Binary) ((AmqpValue) amqp.getBody()).getValue()).getLength());
    --- End diff --
    
    @michaelandrepearce I dont beleive Clebert was talking about removing cross-protocol support, but simply noting that the issue I originally reported only occurred because the broker converted the AMQP message to a 'large' Core message and back (with a loss of detail prior to Tim's changes), when in fact no protocol conversion was really needed since only AMQP producers and consumers were present.


---