[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2113: [ARTEMIS-1890] Any-word wildcard fix


GitHub user jostbg reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/2113

    [ARTEMIS-1890] Any-word wildcard fix

    This patch fixes the reported bug, improves code readability and also improves the performance of the matches function by storing immutable values acquired via method calls in final local variables outside the loop and by avoiding the creation of short-lived temporary objects in the inner loop. Also comments are added for better understanding of the different check steps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jostbg/activemq-artemis ARTEMIS-1890

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2113
    
----
commit b4c4eebe6487fad2bfefbe3bd669e6a32b819f71
Author: Johan Stenberg <jostbg@...>
Date:   2018-05-26T18:12:26Z

    [ARTEMIS-1890] Fix any-word wildcard matching in AddressImpl to match zero words

----


---